-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DDO: Stats and Prices for exchanges/dispensers #774
base: main
Are you sure you want to change the base?
Conversation
…ed in this PR further.
For the moment only ocean-cli test regarding getDDO fails:
I'll put this in review to see if for Metadata events and Order events, I implemented as expected on the specs. |
Have you looked into why the tests are failing? |
Yes, of course I looked into the failure. They fail because on ExchangeCreate event decodedData of the event is null and I cannot retrieve the exchange id -> the event name is wrong |
Fixes #525 .
Changes proposed in this PR: