-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#681 - Update raw save-to-disk #699
Conversation
This PR contains fixes & updates that are required for other PRs to move forward. If your needs for CSVDataStore won't change @kdetry, then perhaps use this. Otherwise, I recommend you cherry-picking changes from as needed to continue with the other PRs and get the DuckDB Integration PR working. I believe we should update CSVDataStore and have it "clean/simple". |
We will continue on the following PR |
Fixes #681
Changes proposed in this PR:
PS: I didn't touch the OHLCV process because it looks like it has its own system and works properly
DoD
Load from + Write to CSVs...Just append
append
append_to_csv
. We just want to append a few rows at at time to a csv with as little latency as possible.append_to_duckdb
. Comment this out. Address this in the next ticket.