Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets the color of the app status bar to match the app background #235

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

wadva474
Copy link

@wadva474 wadva474 commented Oct 13, 2022

This PR sets the app status bar to match the app background and also adds the dark theme for the app bar

screenshots :

Screenshot 2022-10-13 at 18 46 27

Screenshot 2022-10-13 at 18 47 21

@wadva474 wadva474 changed the title chore : Sets the color of the app status bar to match the app background Sets the color of the app status bar to match the app background Oct 13, 2022
@wbrunette
Copy link
Member

@wadva474 looking at your screenshots the buttons ODK-X Tables are not turning white so I cannot see the button icons.

@wadva474
Copy link
Author

wadva474 commented Oct 20, 2022

The Pull Request has been updated to change PNG images used as Menus to SVG so that the menus changes color as the theme changes.
A complementary Pull request has been created on TABLES(odk-x/tables#204). to also make the same change

Complementary PR'S

  1. Services (Set Status Bar services#251)
  2. Tables (Set Status Bar color tables#204)

Attached is a video recording and also screenshots to effect the change.

This also addresses :
odk-x/tool-suite-X#366
odk-x/tool-suite-X#365

Video :
tables_recording.webm

Screenshots :
Screenshot 2022-10-20 at 07 19 05

Screenshot 2022-10-20 at 07 19 25

Screenshot 2022-10-20 at 07 39 30

Screenshot 2022-10-20 at 07 40 03

Screenshot 2022-10-20 at 07 40 26

Screenshot 2022-10-20 at 07 40 55

cc: @wbrunette @maprehensive

@wbrunette
Copy link
Member

@wadva474 I did a quick look and I did not notice anything wrong.

Of course, testing is the only way to make sure by going through all the screens which you might want to do before the final application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants