GUI and Improved Documentation #32
Conversation
|
|
||
| ### Missing Aysnchronous attribute | ||
|
|
||
|  |
There was a problem hiding this comment.
Make the image source relative, so it does not point to a specific fork.
|  | |
|  |
|
|
||
| For quick installation and running purposes simply comment out the use of the server import in main.py. | ||
|
|
||
|  |
There was a problem hiding this comment.
Make the image source relative, so it does not point to a specific fork.
|  | |
|  |
| ``` | ||
| * Use the small tkinter window to carbon date URLs | ||
|
|
||
| *  |
There was a problem hiding this comment.
Make the image source relative, so it does not point to a specific fork.
| *  | |
| *  |
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "AccessToken":["YourBitlyAccessTokenHere"], | |||
| "AccessToken":["Yf7d318a38ee40a5049861a32814bb1b0fb78cb8b"], | |||
There was a problem hiding this comment.
Do we want to provide an access token in the source? This token will perhaps be revoked by GitHub. It is better to tell user how to create a token and then they can use that instead.
| @@ -86,7 +86,7 @@ def run(self, args, **kwargs): | |||
| if args.local_uri: | |||
| url = args.local_uri | |||
| else: | |||
| url = kwargs['url'] | |||
| url = 'https://www.cs.odu.edu/' | |||
There was a problem hiding this comment.
What is the reason of this change?
| def __init__(self, parent, controller): | ||
| def on_entry_click(event): | ||
| """function that gets called whenever entry is clicked""" | ||
| if URIentry.get() == 'https://cs.odu.edu/': |
There was a problem hiding this comment.
Adding hardcoded values like this is not a good practice. If this were to be used as the sample URI, a constant should be defined at the top of the file or better yet, add this in the config file to reuse everywhere.
main.py
Outdated
| elif args.server: | ||
| server.start(args, cfg, mod) | ||
| #elif args.server: | ||
| # server.start(args, cfg, mod) |
There was a problem hiding this comment.
Wait a second, are you completely removing the server functionality and making it a GUI-only application? I am afraid, that I cannot merge this PR here, if this is the case.
|
|
||
|  | ||
|
|
||
| ### Missing/Broken Modules |
There was a problem hiding this comment.
Are these modules broken? Open separate issues with details to either fix or remove them.
| import json | ||
| import time | ||
| import tkinter as tk |
There was a problem hiding this comment.
Need to update requirements.txt to include tkinter and gui.
|
|
||
| ### Missing Aysnchronous attribute | ||
|
|
||
|  |
There was a problem hiding this comment.
I'm kind of curious where this error stems from. I don't have issues with the docker hub image.
Maybe there is a Python version and library version mismatch going on? The docker image is python 3.7 with the following library versions:
$ docker run -it --rm oduwsdl/carbondate bash
root@4d968fac6b3c:/usr/src/app# pip3 list --format freeze
atomicwrites==1.1.5
attrs==18.1.0
beautifulsoup4==4.6.3
certifi==2018.8.13
chardet==3.0.4
idna==2.7
lxml==4.2.4
more-itertools==4.3.0
pip==18.0
pluggy==0.7.1
py==1.5.4
pytest==3.7.1
python-dateutil==2.7.3
requests==2.19.1
requests-file==1.4.3
setuptools==40.0.0
six==1.11.0
surt==0.3.0
tldextract==2.2.0
tornado==5.1
urllib3==1.23
wheel==0.31.1
No description provided.