[Updated] Simplify and fix weather plugin icons rendering

[DimitarCC]

No description provided.

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[jbleyel]

Crash:

15:15:10.2673 File "/usr/lib/enigma2/python/Screens/Screen.py", line 141, in hide
15:15:10.2677 File "/usr/lib/enigma2/python/Components/Renderer/Renderer.py", line 14, in onHide
15:15:10.2680 File "/usr/lib/enigma2/python/Components/Element.py", line 67, in setSuspend
15:15:10.2683 File "/usr/lib/enigma2/python/Components/Renderer/MSNWeatherPixmap.py", line 45, in doSuspend
15:15:10.2686 File "/usr/lib/enigma2/python/Components/Renderer/MSNWeatherPixmap.py", line 66, in changed
15:15:10.2689 File "/usr/lib/enigma2/python/Components/Renderer/MSNWeatherPixmap.py", line 53, in updateIcon
15:15:10.2692 File "/usr/lib/enigma2/python/Tools/LoadPixmap.py", line 8, in LoadPixmap
15:15:10.2696 TypeError: 'NoneType' object is not subscriptable
15:15:10.2696 [ePyObject] (PyObject_CallObject(<bound method ActionMap.action of <Components.ActionMap.ActionMap object at 0xada1ff60>>,('SetupActions', 'menu')) failed)

[Huevos]

Is this crash in OpenATV?

[jbleyel]

Yes and in many other images.

[jbleyel]

LoadPixmap(None) -> Crash

[DimitarCC]

The question here is why it is None at first place. I guess incorrect path or missing icon... Изпратено от Outlook за Android<https://aka.ms/AAb9ysg>

…

________________________________ From: jbleyel ***@***.***> Sent: Friday, August 23, 2024 8:03:38 PM To: oe-alliance/enigma2-plugins ***@***.***> Cc: Dimitar Tsenev ***@***.***>; Author ***@***.***> Subject: Re: [oe-alliance/enigma2-plugins] [Updated] Simplify and fix weather plugin icons rendering (PR #676) LoadPixmap(None) -> Crash — Reply to this email directly, view it on GitHub<#676 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAORCBOQNHEK4U5BDL37EGLZS5TOVAVCNFSM6AAAAABMA5DDPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBXGQ3TONZQGU>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[jbleyel]

The question here is why it is None at first place. I guess incorrect path or missing icon...

ba57023

[Huevos]

How will that work? Won't it just raise the exception?

https://github.com/openatv/enigma2/blob/master/lib/python/Tools/LoadPixmap.py#L28

[jbleyel]

It's only a workaround and quick fix to prevent the crash.
The whole code needs a review but i will not do that.

[Huevos]

But it file name is empty it will crash.

[jbleyel]

But it file name is empty it will crash.

Then you need to stop calling LoadPixmap if empty.

[Huevos]

The None call in the original code was to remove the icon.

[jbleyel]

The None call in the original code was to remove the icon.

LoadPixmap(None) ->

15:15:10.2692 File "/usr/lib/enigma2/python/Tools/LoadPixmap.py", line 8, in LoadPixmap
15:15:10.2696 TypeError: 'NoneType' object is not subscriptable

[jbleyel]

You need to do this:

self.instance.setPixmap(None)

[jbleyel]

	def updateIcon(self, filename):
		new_IconFileName = filename
		if (self.iconFileName != new_IconFileName):
			self.iconFileName = new_IconFileName
			if self.iconFileName:
				self.pix = LoadPixmap(self.iconFileName)
				try:
					self.instance.setPixmapScale(BT_SCALE | BT_KEEP_ASPECT_RATIO)
				except:
					self.instance.setScale(1)
				self.instance.setPixmap(self.pix)
			else:
				self.instance.setPixmap(None)