Feat/update v0.4.1 #132
Merged
Feat/update v0.4.1 #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b3/ssl. upgrade to ubuntu-22.04?
|
Is this ready for review/merge? |
|
@ofek, yes, it passes the conda recipe checks as well |
|
@ofek Are there changes needed? |
ofek
requested changes
Jan 11, 2024
ofek
requested changes
Jan 11, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
* (feat) secp256k1 v0.4.0 * (feat) CFFI for new support * (fix) Could not figure out why egg_info adds absolute paths. Prune them * (feat) Use TOML project definition. Version bump to 19.0.0 * (feat) Use TOML project definition. Version bump to 19.0.0 * (feat) tox with python 3.12 * (fix) copy-paste fumble * (fix) missing EOL * (fix) relaxed setuptools constraint * (fix) issues with mkdocstring * (ref) remove unnecessary dependence * (ref) remove deprecated functions * (fea) selectable download using pkg-config * (fix) path to header for windows * (fix) don't remember why zzz * (fix) bypass download for windows? * (fix) bypass download for windows. lint check * (fix) use pkgconfig to resolve lib location in windows? * (fix) odd ruff fail * (dbg) trying to figure out the windows annoyance * (dbg) trying to figure out the windows annoyance * (fix) ffi.dlopen() needs full lib name under windows? * (dbg) linking on windows requires to prepend with 'lib', how to do that? * (fix) linking on windows requires to prepend with 'lib' * (fix) catch PackageNotFoundError when detecting system libsecp256k1 * (fix) wrong PackageNotFoundError? * (dbg) libname on windows * (fix) build for linking shared libsecp256k1 on windows * Apply suggestions from code review * (ref) Move library to API (instead of ABI) * (fix) There's an issue with import pkgconfig on windows ... * (fix) There's an issue with import pkgconfig on windows ... * (fix) Turning in circles around windows ... * (fix) Turning in circles around windows ... * (fix) The issue is when building with setup.py (not TOML) * (fix) remove pkgconfig, usr pkg-config instead? * (fix) fmt * (fix) subprocess fails if command exists with 1 * (fix) back to guessing game :\ * (ref) Let's have a pkg name, UNKNOWN-0.0.0 is too mysterious * (fea) Update to SECP256K1 v0.4.1 * (fea) which part of "IMPORTANT: Keep in sync" did I not understand? * (fix) broke the build with system libs :,( * (ref) forgot to re-enable windows selection for libname change. deprec distutils * (ref) update workflow to python 3.12. cibuildwheels to 2.16.2 * (ref) update workflow to python 3.12. cibuildwheel fails due to urllib3/ssl * (ref) update workflow to python 3.12. cibuildwheel fails due to urllib3/ssl. upgrade to ubuntu-22.04? * (bld) urllib3>2? * (fix) missing Distribution for system lib case? * (fix) retrofit cibuildwheel to 2.11.2 for linux (urllib3/ssl issue) * (fix) why is it not finding the lib? * (fix) why is it not finding the lib? * (fix) why is it not finding the lib? * (dbg) why is it not finding the lib? * (dbg) too fast to simplify, header not found! * (fix) path to headers found? * (fix) byte to string * (fix) lint/fmt * (dbg) back to squre one on conda recipe ... it downloads :/ * (ref) silly, I don't need to commit, just patch-debug the recipe * (ref) silly, I don't need to commit, just patch-debug the recipe * (ref) silly, I don't need to commit, just patch-debug the recipe * (ref) correct differences between pkg-config and pkgconfig * (fix) Do we need env? * Apply suggestions from code review * Apply suggestions from code review --------- Co-authored-by: Ofek Lev <[email protected]> ff39dd7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly add support for the new features of SECP256K1.
The .h are created automatically from the sec256pk1 with gcc -E (and a few tricks) so it formats a little oddly, creating lots of changes (like int* a -> int *a) which may make the review tedious
In the conda recipe (and the github repo for libsecp256k1-py-bindings), the build.py was modified to make it more automated and able to add either dynamic or static Clib. The compilation also uses an ABI version of CFFI lib