Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: missing _windows_libsecp256k1.py CONTEXT_SIGN & CONTEXT_VERIFY #139

Closed
wants to merge 1 commit into from

Conversation

MementoRC
Copy link
Collaborator

The flags for the windows _windows_libsecp256k1.py are missing (oversight in the previous PR)

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc3cdbd) 85.86% compared to head (9560589) 85.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #139   +/-   ##
=======================================
  Coverage   85.86%   85.86%           
=======================================
  Files          11       11           
  Lines         573      573           
  Branches       66       66           
=======================================
  Hits          492      492           
  Misses         45       45           
  Partials       36       36           

@MementoRC
Copy link
Collaborator Author

@ofek Should we update flags.py to only import the non-deprecated flags, but still keep them in the CFFI since they are still part of the SECP256K1 library?
We could also, just leave it as it is now, or remove them completely - let me know I'll submit the next PR depending upon your preference

@ofek
Copy link
Owner

ofek commented Jan 27, 2024

I would prefer to completely remove deprecated stuff, and please let me know what is breaking compared to v18 so I can document it.

@MementoRC
Copy link
Collaborator Author

Ok, then, i close this PR and resubmit a clean-up one

@MementoRC MementoRC closed this Jan 27, 2024
@MementoRC MementoRC deleted the fix/missing_windows_flag branch January 27, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants