Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: from setup to pyproject #161

Merged
merged 9 commits into from
Mar 20, 2024

Conversation

MementoRC
Copy link
Collaborator

Let's try to transition more metadate from setup to pyproject, this way when we hatch, it'll be simpler and both setuptools and hatchling may be tested in quasi-parallel

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.68%. Comparing base (b9f0930) to head (a5c8f2a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files          11       11           
  Lines         566      566           
  Branches       67       67           
=======================================
  Hits          485      485           
  Misses         45       45           
  Partials       36       36           

@MementoRC MementoRC self-assigned this Mar 19, 2024
@MementoRC MementoRC requested a review from ofek March 20, 2024 00:06
.github/scripts/build-windows-wheels.sh Outdated Show resolved Hide resolved
@MementoRC MementoRC requested a review from ofek March 20, 2024 15:39
@MementoRC
Copy link
Collaborator Author

MementoRC commented Mar 20, 2024

@ofek I stumbled upon a lot of discussions about build systems, maybe at some point we should use scikit-build? Also, is the version.py suitable for hatch..version ?
I mistakenly committed a comment hinting at transition to hatch, I'll leave it for now since you already approved

@MementoRC MementoRC merged commit 5e46aca into ofek:master Mar 20, 2024
11 checks passed
@MementoRC MementoRC deleted the feat/refactor-setup-to-pyproject branch March 20, 2024 15:58
@ofek
Copy link
Owner

ofek commented Mar 20, 2024

Specifically, the new one https://github.com/scikit-build/scikit-build-core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants