feat(themes): new theme nekonight cupcake theme variant #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
reviewed
Jan 21, 2025
There was a problem hiding this comment.
Thanks for your contribution. Could you check the "New Theme" section of CONTRIBUTING.md?
Of course, I'm already going there |
|
Did it get better? |
akinomyoga
reviewed
Jan 21, 2025
akinomyoga
reviewed
Jan 21, 2025
akinomyoga
reviewed
Jan 21, 2025
Thanks for updating. Yes, it became definitely better, but there are remaining issues. |
|
I hope it's resolved now, in the meantime I've already made another theme and soon after this one is accepted (if it is) I'll send another pull request |
Co-authored-by: Koichi Murase <[email protected]>
akinomyoga
reviewed
Jan 21, 2025
|
I think everything is ok now |
akinomyoga
reviewed
Jan 21, 2025
akinomyoga
approved these changes
Jan 21, 2025
|
Thanks for your quick responses and patience. I've merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New cupcake theme variant, based on the nekonight cross platform theme collection