Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Parameter update delay at specific block height #243

Merged
merged 17 commits into from
Sep 15, 2023

Conversation

rbajollari
Copy link
Collaborator

Description

closes: #96


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Merging #243 (f88b32c) into main (cc615f6) will decrease coverage by 0.26%.
Report is 1 commits behind head on main.
The diff coverage is 16.66%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
- Coverage   18.79%   18.53%   -0.26%     
==========================================
  Files          51       53       +2     
  Lines       12277    12907     +630     
==========================================
+ Hits         2307     2392      +85     
- Misses       9839    10392     +553     
+ Partials      131      123       -8     
Files Changed Coverage Δ
x/oracle/types/keys.go 85.71% <0.00%> (-6.60%) ⬇️
x/oracle/types/plan.go 0.00% <0.00%> (ø)
x/oracle/types/oracle.pb.go 0.50% <0.43%> (-0.01%) ⬇️
x/oracle/types/tx.pb.go 0.64% <0.58%> (-0.01%) ⬇️
x/oracle/types/msgs.go 68.46% <15.00%> (+19.04%) ⬆️
x/oracle/types/proposal.go 25.00% <16.66%> (-8.34%) ⬇️
x/oracle/keeper/msg_server.go 66.66% <52.63%> (+3.57%) ⬆️
x/oracle/types/params.go 78.74% <61.70%> (-0.97%) ⬇️
x/oracle/keeper/param_update_plan.go 96.66% <96.66%> (ø)
x/oracle/abci.go 81.10% <100.00%> (+0.93%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rbajollari rbajollari marked this pull request as ready for review August 15, 2023 18:48
@rbajollari rbajollari requested a review from a team as a code owner August 15, 2023 18:48
@adamewozniak
Copy link
Member

@zarazan please review 🙏

Copy link
Contributor

@zarazan zarazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that this makes the code cleaner in some spots.

x/oracle/keeper/keeper.go Outdated Show resolved Hide resolved
x/oracle/types/plan.go Show resolved Hide resolved
x/oracle/abci.go Show resolved Hide resolved
@rbajollari rbajollari merged commit cf2a0bb into main Sep 15, 2023
@rbajollari rbajollari deleted the ryan/param-update-delay branch September 15, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter update delay at specific block height
4 participants