-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrade tia branch to cosmos sdk v0.50.1 (backport #382) #391
Conversation
Cherry-pick of 8649e17 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
for _, key := range app.keys { | ||
keys = append(keys, key) | ||
} |
Check warning
Code scanning / CodeQL
Iteration over map Warning
for _, m := range app.mm.Modules { | ||
if moduleWithName, ok := m.(module.HasName); ok { | ||
moduleName := moduleWithName.Name() | ||
if appModule, ok := moduleWithName.(appmodule.AppModule); ok { | ||
modules[moduleName] = appModule | ||
} | ||
} | ||
} |
Check warning
Code scanning / CodeQL
Iteration over map Warning
if k.IsPeriodLastBlock(ctx, params.VotePeriod) { | ||
if err := CalcPrices(ctx, params, k); err != nil { | ||
if k.IsPeriodLastBlock(sdkCtx, params.VotePeriod) { | ||
if err := CalcPrices(sdkCtx, params, k); err != nil { |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
* project builds * fix unit tests * go version in workflows * some lint issues * fix sim non determinism * go version in workflows * single node fix * fix rollkit init-local * init-local works * try liveness with init-local * update init_local to work in CI * script permisions * remove it option from docker run * make celestia devnet run in background * rollup script too * comment out e2e * some lint fixes * use version latest in golangci-lint action * more lint fixes * silence lint error on usage of deprecated func * fix .golangci.yml formatting * add extra sleep in liveness * cometbft to v0.38.5 * Update cmd/ojod/cmd/commands.go Co-authored-by: Adam Wozniak <[email protected]> * move TODO to top of file --------- Co-authored-by: Adam Wozniak <[email protected]> (cherry picked from commit 8649e17) # Conflicts: # go.mod # go.sum # scripts/celestia_devnet.sh # tools/tools.go
10ad14b
to
73656e5
Compare
This is an automatic backport of pull request #382 done by Mergify.
Cherry-pick of 8649e17 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com