Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/share data step 3 validation #494

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

loiclaudet
Copy link
Contributor

@loiclaudet loiclaudet commented Oct 4, 2023

Purpose

The user can currently reach step 4 although the dataset title field is required in step 3.

This PR add text field validation for shareData step 3.

TODO

  • Error handling - We need more details about errors management.

@loiclaudet loiclaudet added the feature 🤌 new features label Oct 4, 2023
@loiclaudet loiclaudet self-assigned this Oct 4, 2023
Copy link
Member

@bot-anik bot-anik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop http://localhost:4173/

Device URL
mobile http://localhost:4173/

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@loiclaudet loiclaudet force-pushed the feat/share-data-step3-validation branch 2 times, most recently from 5d61ca1 to 60b2011 Compare October 5, 2023 07:04
@loiclaudet loiclaudet marked this pull request as draft October 5, 2023 13:25
@loiclaudet loiclaudet force-pushed the feat/share-data-step3-validation branch from 60b2011 to 502f514 Compare October 6, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🤌 new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants