Control stdio for process credentials output #261
Merged
+213
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for a follow on feature refactor.
okta-aws-cli is outputting to. Closes #247
arvindkrishnakumar-okta
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #247, when okta-aws-cli is in credential process format output we can't print to stderr as it will cause aws cli to fail when it exec's okta-aws-cli (docs for AWS CLI credential_process)
This PR introduces a logger interface for printing log messages. For example, the logger for credential process disables printing to STDERR. All logging goes through the interface rather than sprinkling
fmtprint functions throughout the codebase.Also includes a small refactor for better idiomatic naming of constructor functions.