fix: polling issues on ios18 devices #3749
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| script_name: testcafe-mobile | ||
| criteria: MERGE | ||
| queue_name: small | ||
| # - name: testcafe |
There was a problem hiding this comment.
I won't merge this, this was just to get a downstream build to deploy for testing
| _startAuthenticatorPolling() { | ||
| console.log('queued poll action'); |
There was a problem hiding this comment.
TODO: remove
shawyu-okta
reviewed
Nov 14, 2024
| // prevent the next poll network request from being sent | ||
| this.stopPolling(); | ||
| this.pausedForWindowUnfocus = true; | ||
| this._handleWindowRefocusWhilePolling(); |
There was a problem hiding this comment.
Is there a good way to combine the two visibility listener functions so we don't need to split the logic across two methods?
| const pageVisibilityHandler = () => { | ||
| if (!document.hidden && this.pausedForWindowUnfocus) { | ||
| this.pausedForWindowUnfocus = false; | ||
| this.startPolling(100); |
There was a problem hiding this comment.
Do we have to wait 100ms? Does using 0 as the polling interval cause any issues?
| const clonedPollingStep = getPollingStep(clonedTransaction); | ||
| if (clonedPollingStep !== undefined) { | ||
| clonedPollingStep.refresh = 60000; | ||
| const queuePollRequest = () => { |
There was a problem hiding this comment.
Could this function be defined outside of the effect?
| queuePollRequest(); | ||
|
|
||
| let visListener: (() => void) | null = null; | ||
| if (BrowserFeatures.isIOS()) { |
There was a problem hiding this comment.
Add the same comment here that you added in the Gen2 code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When the browser window (either Safari or Chrome) is hidden during a polling flow, requests made while the browser is not active fail causing the overall flow to fail
PR Checklist
Issue:
Reviewers:
Screenshot/Video:
Downstream Monolith Build: