-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OKTA-826614 add grace period support for v2 & v3 #3769
base: master
Are you sure you want to change the base?
Conversation
src/v3/src/mocks/response/idp/idx/introspect/authenticator-enroll-grace-period-with-skip.json
Outdated
Show resolved
Hide resolved
src/v3/src/transformer/selectAuthenticator/transformSelectAuthenticatorEnroll.ts
Outdated
Show resolved
Hide resolved
e859470
to
7ce6fd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Ready for demo cell / e2e testing
* @param {Integer} epoch2 epoch timestamp in milliseconds as an integer | ||
* @return {Integer} The number of days between the two epoch timestamps | ||
*/ | ||
calculateDaysBetweenEpochTimestamps(epoch1, epoch2) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add unit test for this util function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have unit tests in TimeUtil_spec.js starting on line 155 here 🙂 : https://github.com/okta/okta-signin-widget/pull/3769/files/10a139eace839ce76ab7614508e4b65d47e746a9#diff-6f8c4193d90fd1b20ea606fe118b204009c54689dfe5dd519ffdbc5bbad68859R155
2548bb7
to
37d8a72
Compare
d1f4872
to
eb42feb
Compare
Description:
Required Now
orRequired Soon
listRequired Soon
authenticators will display grace period elements that show the exact grace period date + time (in user locale and time zone) along with a relative time statement i.e.Required in {x} days
orRequired today
Remind me later
button (backend will handle how this button redirects to optional authenticators)Optional
authenticators screen should remain the sameformatDateToDeviceAssuranceGracePeriodExpiryLocaleString
to display exact grace period date + timePR Checklist
Issue:
Reviewers:
Screenshot/Video:
V2 screenshots:
V3 screenshots:
Downstream Monolith Build: