Issue 288 javafx windows10 #310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aries without runtime scope updated to build on jdk11
…rsing the available roles from the SAML token. The bug was that they were inverted and AWS STS refused the call because the role name was invalid.
Updated gitignore with intellij recommended rules
…sion and cookies were in place. Added a condition that throws an exception to trigger authentication with user credentials if no cookies from a previous session are present. This avoids a crash when tool is fresh installed and no previous session cookies are present
…name in the RoleOption entity for the roles selection menu. Reenabled test that was failing before
|
Please remove the .idea directory that’s included in this PR and ignore it in .gitignore.
… On Jun 10, 2019, at 07:21, Hector Salazar ***@***.***> wrote:
Updated README to mention JDK 11 instead of 8
You can view, comment on, or merge this pull request online at:
#310
Commit Summary
updated to javafx
Removed reference to broken protocol handler
Fixed compile errors by updating Maven pom to use the openjavafx libraries without runtime scope
Bugfix: set the rolesArn's as key and principalArn's as value when parsing the available roles from the SAML token. The bug was that they were inverted and AWS STS refused the call because the role name was invalid.
Added IntelliJ idea build configurations.
previous logic was assuming that always was refreshing a previous session and cookies were in place.
Fixed crash if no command line options were provided after okta command
Created IntelliJ run configurations for list roles and sls commands
Fixed maven broken dependency on javafx pom
Disabled test tied to an specific AWS account
Fixed bug in roles list parsing after bugfix to set the role arn and name in the RoleOption entity for the roles selection menu.
Set openjdk11 in CI/CD
Updated documention to update JDK mentions to version 11 or later
File Changes
M .gitignore (55)
A .idea/.name (1)
A .idea/compiler.xml (13)
A .idea/encodings.xml (6)
A .idea/misc.xml (14)
A .idea/runConfigurations/ListOktaRoles_JDK11___list_roles.xml (18)
A .idea/runConfigurations/OktaSLS_JDK11.xml (17)
A .idea/runConfigurations/WithOkta_JDK11.xml (17)
A .idea/runConfigurations/WithOkta_JDK12.xml (11)
A .idea/vcs.xml (6)
M .travis.yml (2)
M Readme.MD (2)
M pom.xml (51)
M src/main/java/com/okta/tools/WithOkta.java (9)
M src/main/java/com/okta/tools/helpers/RoleHelper.java (2)
M src/main/java/com/okta/tools/io/LoginPageInterceptingProtocolHandler.java (31)
M src/main/java/com/okta/tools/io/SubresourceIntegrityStrippingHack.java (3)
M src/main/java/com/okta/tools/saml/AwsSamlRoleUtils.java (2)
M src/main/java/com/okta/tools/saml/OktaAppClientImpl.java (9)
M src/main/java/com/okta/tools/saml/OktaSaml.java (8)
A src/main/main.iml (11)
M src/test/java/com/okta/tools/RoleHelperTest.java (1)
A src/test/test.iml (12)
Patch Links:
https://github.com/oktadeveloper/okta-aws-cli-assume-role/pull/310.patch
https://github.com/oktadeveloper/okta-aws-cli-assume-role/pull/310.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
…re as per request of maintainer
…-role # Conflicts: # pom.xml
|
@hecsalazar Please resolve conflicts in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated README to mention JDK 11 instead of 8