Rename fix, correct typo

oleks-rip · Jan 17, 2025 · 4444d42 · 4444d42
1 parent 6137a6e
commit 4444d42
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 8 deletions.
diff --git a/include/xrpl/protocol/detail/features.macro b/include/xrpl/protocol/detail/features.macro
@@ -29,8 +29,8 @@
 // If you add an amendment here, then do not forget to increment `numFeatures`
 // in include/xrpl/protocol/Feature.h.
 
-// fix1782: Check flags in Credential transactions
-XRPL_FIX    (1782,                       Supported::yes, VoteBehavior::DefaultNo)
+// Check flags in Credential transactions
+XRPL_FIX    (CredentialFlags,            Supported::yes, VoteBehavior::DefaultYes)
 XRPL_FEATURE(PermissionedDomains,        Supported::no,  VoteBehavior::DefaultNo)
 XRPL_FEATURE(DynamicNFT,                 Supported::yes, VoteBehavior::DefaultNo)
 XRPL_FEATURE(Credentials,                Supported::yes, VoteBehavior::DefaultNo)

diff --git a/src/test/app/Credentials_test.cpp b/src/test/app/Credentials_test.cpp
@@ -1075,9 +1075,9 @@ struct Credentials_test : public beast::unit_test::suite
             env.close();
 
             {
-                bool const enabled = features[fix1782];
+                bool const enabled = features[fixCredentialFlags];
                 testcase(
-                    std::string("Tets flag, fix ") +
+                    std::string("Test flag, fix ") +
                     (enabled ? "enabled" : "disabled"));
 
                 ter const expected(
@@ -1106,7 +1106,7 @@ struct Credentials_test : public beast::unit_test::suite
         testAcceptFailed(all);
         testDeleteFailed(all);
         testFeatureFailed(all - featureCredentials);
-        testFlags(all - fix1782);
+        testFlags(all - fixCredentialFlags);
         testFlags(all);
         testRPC();
     }

diff --git a/src/xrpld/app/tx/detail/Credentials.cpp b/src/xrpld/app/tx/detail/Credentials.cpp
@@ -65,7 +65,8 @@ CredentialCreate::preflight(PreflightContext const& ctx)
     auto const& tx = ctx.tx;
     auto& j = ctx.j;
 
-    if (ctx.rules.enabled(fix1782) && (tx.getFlags() & tfUniversalMask))
+    if (ctx.rules.enabled(fixCredentialFlags) &&
+        (tx.getFlags() & tfUniversalMask))
     {
         JLOG(ctx.j.debug()) << "CredentialCreate: invalid flags.";
         return temINVALID_FLAG;
@@ -215,7 +216,8 @@ CredentialDelete::preflight(PreflightContext const& ctx)
     if (auto const ret = preflight1(ctx); !isTesSuccess(ret))
         return ret;
 
-    if (ctx.rules.enabled(fix1782) && (ctx.tx.getFlags() & tfUniversalMask))
+    if (ctx.rules.enabled(fixCredentialFlags) &&
+        (ctx.tx.getFlags() & tfUniversalMask))
     {
         JLOG(ctx.j.debug()) << "CredentialDelete: invalid flags.";
         return temINVALID_FLAG;
@@ -301,7 +303,8 @@ CredentialAccept::preflight(PreflightContext const& ctx)
     if (auto const ret = preflight1(ctx); !isTesSuccess(ret))
         return ret;
 
-    if (ctx.rules.enabled(fix1782) && (ctx.tx.getFlags() & tfUniversalMask))
+    if (ctx.rules.enabled(fixCredentialFlags) &&
+        (ctx.tx.getFlags() & tfUniversalMask))
     {
         JLOG(ctx.j.debug()) << "CredentialAccept: invalid flags.";
         return temINVALID_FLAG;