Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix left/right movement of caret while editing with selectRange enabled. #4620

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andy-5
Copy link

@andy-5 andy-5 commented Nov 8, 2024

This is a fix for #4563.

I'm not sure why keyNavigate and keyNavigateRange always called e.preventDefault(), but using just the commented line inside the if block fixes caret movement while editing.

Or is there any reason to call e.preventDefault() even if range-navigation is not allowed?
I think the event handlers should not have any effect in this case, as implemented in this PR.

@azmy60 azmy60 self-requested a review January 22, 2025 08:45
Copy link
Collaborator

@azmy60 azmy60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the PR! It was commented because the page would scroll if you press arrow keys when you're no longer able to navigate at the side of the table. It was from this PR: #4474

I should've implemented a better solution, so .preventDefault inside the if statement is fine. But we also need to address the issue I mentioned. Probably this.navigate should return true even if the range is not moved.

@andy-5
Copy link
Author

andy-5 commented Jan 22, 2025

I changed it so that this.navigate returns true even if the range is not moved, as you suggested. This seems to work great (tested also with the example linked in #4474).

Copy link
Collaborator

@azmy60 azmy60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants