-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels properties are a dict of lists #12
Labels properties are a dict of lists #12
Conversation
Needed by from napari import conftest, since napari test deps aren't installed
@@ -32,6 +32,7 @@ deps = | |||
# you can remove these if you don't use them | |||
napari | |||
magicgui | |||
pooch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does pooch
get used, @will-moore ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous run failure: https://github.com/ome/napari-ome-zarr/runs/3651193426
.tox/py37-linux/lib/python3.7/site-packages/napari/conftest.py:5
>>> import pooch
ModuleNotFoundError
pooch
is listed as a test dependency of napari
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As pooch
is a testing
dependency of napari
(https://github.com/napari/napari/blob/95a5d06fe36f10fb26f5798f1327a3ea082d581f/setup.cfg#L105), updating https://github.com/ome/napari-ome-zarr/blob/main/tox.ini#L33 with
- napari
+ napari[testing]
would be another option. Does it bring too many extra dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just trying this locally into my existing napari & ome-zarr-py env:
$ pip install -U napari[testing]
This download 8 packages, mostly very small (few MB or less) except torch
(218 MB). 🤷
With origin/main, I still see the error from #6: With this PR, the image & label layers load. I note that I see a separate error when viewing the labels in 3D:
|
@joshmoore No idea what's up with the 3D labels, but I don't think it's related to this PR. |
I created #14. Merging. |
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/tool-for-adding-labels-group-to-ome-ngff/72839/4 |
Fixes #6.
This updates
napari-ome-zarr
to transform label properties into the format that napari is now expecting, usingindex
as the label ID as described at https://forum.image.sc/t/napari-labels-layer-properties/57649e.g.
To test, using data exported from
omero-cli-zarr
at PR: ome/omero-cli-zarr#82Mousing over a label should show associated values in the footer: