Simplify testing setup + Python 3.12 tests #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
changed the title
will-moore
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Looks good, Thanks.
We now have 18 Checks for this PR at https://github.com/ome/ome-zarr-py/pull/338/checks compared with 12 at previously merged PR
https://github.com/ome/ome-zarr-py/pull/326/checks so more complete coverage.
joshmoore
reviewed
Dec 7, 2023
| with: | ||
| python-version: ${{ matrix.python_version }} | ||
|
|
||
| - name: Install ubuntu libraries |
There was a problem hiding this comment.
I'm concerned that by skipping these we're now omitting a test. Or did those tests get moved to napari-ome-zarr, @will-moore?
dstansby
commented
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a bit distracted by wanting to add Python 3.12 testing here 😄 This generally cleans up the testing infastructure by:
tox.iniand the GitHub action configurationI also noticed
fsspec==2023.6.0was pinned for tests, but newer versions offsspecbreak the tests. So I've pinnedfsspecinsetup.pycorrectly.