Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of pyupgrade #397

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Update version of pyupgrade #397

merged 2 commits into from
Dec 10, 2024

Conversation

dstansby
Copy link
Contributor

This updates the version of pyupgrade to match the minimum supported version of the package, and makes the corresponding pyupgrade fixes.

Copy link

codecov bot commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 97.22222% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.45%. Comparing base (4c8e990) to head (72f512d).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
ome_zarr/csv.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #397   +/-   ##
=======================================
  Coverage   85.44%   85.45%           
=======================================
  Files          13       13           
  Lines        1539     1540    +1     
=======================================
+ Hits         1315     1316    +1     
  Misses        224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshmoore
Copy link
Member

@dstansby: can you handle the conflicts here?

@dstansby
Copy link
Contributor Author

👍 should be updated and fixed now

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @will-moore, any concerns about getting this in now?

@will-moore
Copy link
Member

LGTM 👍

@jburel jburel merged commit ec7f2ad into ome:master Dec 10, 2024
16 checks passed
@dstansby dstansby deleted the bump-pyupgrade branch December 10, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants