Fix dimension separator when downloading files #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #419 +/- ##
=======================================
Coverage 85.45% 85.45%
=======================================
Files 13 13
Lines 1540 1540
=======================================
Hits 1316 1316
Misses 224 224 ☔ View full report in Codecov by Sentry. |
dstansby
force-pushed
the
check-downloaded-files
branch
from
073d009 to
d6a822b
Compare
will-moore
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Thanks!
Testing with:
ome_zarr download https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.4/idr0101A/13457539.zarr
napari --plugin napari-ome-zarr ./13457539.zarr
this fixes the failure reported at thewtex/ngff-zarr#125 (comment)
And the data is valid as reported by the validator with
ome_zarr view ./13457539.zarr
|
Thanks all. Releasing as 0.10.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #231
I saw there's a fix in #404 too, but I thought a self-contained fix would be easier/quicker to ship. This PR also includes a test, which I don't think #404 has.