Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker_appdir path in omeroweb CreateApp.rst #2134

Merged
merged 2 commits into from
Jul 15, 2020
Merged

Fix docker_appdir path in omeroweb CreateApp.rst #2134

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ae9a2b
Fix docker_appdir path in omeroweb CreateApp.rst
will-moore Jun 23, 2020
104b381
remove remaining ref to python 2.7
jburel Jun 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions omero/developers/Web/CreateApp.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ python can import our ``minimal_webapp`` module.
$ appdir=$(pwd)/minimal-webapp/minimal_webapp

# Location within Docker instance we want to link the app, so it can be imported.
$ docker_appdir=/opt/omero/web/venv/lib/python2.7/site-packages/minimal_webapp
$ docker_appdir=/opt/omero/web/venv3/lib/python3.6/site-packages/minimal_webapp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that it need beed done in this PR, but @manics, is there anything that could be done in the omero-web(-standalone) app to make this registration easier? A symlink from /apps? A .pth file? etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does -e PYTHONPATH=/mountpoint work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I set $appdir so that

$ echo $appdir 
/Users/wmoore/Desktop/WEB-APP-EXAMPLES/omero-web-apps-examples/minimal-webapp/

This allows me to import the app locally:

$ export PYTHONPATH=$appdir
$ python
>>> import minimal_webapp

But this doesn't work:

$ docker run -it --rm -e OMEROHOST=$host -p 4080:4080 -e PYTHONPATH=$appdir -v $config:$docker_config openmicroscopy/omero-web-standalone
...
ModuleNotFoundError: No module named 'minimal_webapp'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll still need to mount it inside the docker image. E.g.

appdir=$PWD/omero-metadata/src
docker run -it --rm ... -e PYTHONPATH=/apps -v $appdir:/apps --name test openmicroscopy/omero-web-standalone

$ docker exec -it test python -c 'import omero_metadata; print(omero_metadata.__file__)'
/apps/omero_metadata/__init__.pyc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #2140 to look into this - but not essential for this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @will-moore, merging


# This example config file installs "minimal_webapp". See the file for more details.
$ config=$(pwd)/config.omero
Expand All @@ -101,8 +101,8 @@ that OMERO.web is starting and the static files from your app are being included
::

...
Copying '/opt/omero/web/venv/lib/python2.7/site-packages/minimal_webapp/static/minimal_webapp/app.css'
Copying '/opt/omero/web/venv/lib/python2.7/site-packages/minimal_webapp/static/minimal_webapp/app.js'
Copying '/opt/omero/web/venv3/lib/python3.6/site-packages/minimal_webapp/static/minimal_webapp/app.css'
Copying '/opt/omero/web/venv3/lib/python3.6/site-packages/minimal_webapp/static/minimal_webapp/app.js'
...
Starting OMERO.web...

Expand Down