Upgrade schemas to draft 2020-12 #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
force-pushed
the
schema-2020-12
branch
from
50de2a3 to
b8f8aeb
Compare
antpb
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade JSON schemas to draft 2020-12, from draft 04. Khronos has already upgraded the core glTF schemas to the newer draft 2020-12 and doing so for extensions is still a work-in-progress. See KhronosGroup/glTF#2049 for discussion. Changes include:
"$id"to each schema."enum"to"const"."exclusiveMinimum": 0.0instead of"minimum": 0.0and"exclusiveMinimum": true.I also ensured all schemas were in a consistent order and had descriptions. While not technically related to upgrading the schema version, it was easiest to just do these things at the same time while I was combing over the schemas anyway.