Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: apply the adena-wallet-sdk response type #594

Merged
merged 3 commits into from
Oct 16, 2024
Merged

feat: apply the adena-wallet-sdk response type #594

merged 3 commits into from
Oct 16, 2024

Conversation

jinoosss
Copy link
Member

What type of PR is this?

  • feat

What this PR does:

  • Add the adena-wallet-sdk dependency.
  • Defines the response type of the Adena wallet's injection function.
  • Apply the adena-wallet-sdk response type.

@jinoosss jinoosss requested a review from a team as a code owner September 27, 2024 09:10
dongwon8247
dongwon8247 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@dongwon8247 dongwon8247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done. Do you want to add other injection methods you will be working on and merge this PR? or want to merge this first? up to you.

@jinoosss
Copy link
Member Author

Thanks for the review !
I'm going to work on merging this first.
I'll update it along with the SDK when some injection methods are added.

@jinoosss jinoosss merged commit cb15871 into main Oct 16, 2024
2 checks passed
@jinoosss jinoosss deleted the ADN-615-apply-adena-wallet-sdk branch October 16, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongwon8247 dongwon8247 dongwon8247 approved these changes

@onlyhyde onlyhyde Awaiting requested review from onlyhyde onlyhyde is a code owner automatically assigned from onbloc/core-engineers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinoosss @dongwon8247