[Bug][Help] Fixed all the categories getting printing for --help #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiweij1
reviewed
Jan 9, 2025
zhiweij1
reviewed
Jan 9, 2025
zhiweij1
approved these changes
Jan 9, 2025
zhiweij1
reviewed
Jan 9, 2025
llvm/lib/Support/CommandLine.cpp
Outdated
| @@ -2980,7 +2980,7 @@ void HelpPrinterWrapper::operator=(bool Value) { | |||
| #ifdef SYCLomatic_CUSTOMIZATION | |||
| void HelpPrinterWrapper::operator=(CtHelpCategory Value) { | |||
| CategorizedPrinter.setReqCtHelpCategory(Value); | |||
| cl::HideUnrelatedOptions(CategorizedPrinter.getReqCtHelpCategory(Value)); | |||
| // cl::HideUnrelatedOptions(CategorizedPrinter.getReqCtHelpCategory(Value)); | |||
There was a problem hiding this comment.
If it is not needed, please remove this line.
There was a problem hiding this comment.
Upon further analysis, decided to retain it
TejaX-Alaghari
force-pushed
the
fixes
branch
2 times, most recently
from
902afcb to
1a40993
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug where opts from all the cat are printed when dpct --help is called with no options resulting in duplicate entries.
Expected behavior is to print all the options only once.
Here is the sample output: