Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update form-type.csv and BT-03 guidance #233

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

odscjen
Copy link
Contributor

@odscjen odscjen commented Dec 5, 2024

closes #231

output/mapping/eforms/guidance.yaml Show resolved Hide resolved
output/mapping/eforms/guidance.yaml Show resolved Hide resolved
output/mapping/eforms/mapping-tables/form-type.csv Outdated Show resolved Hide resolved
competition,"The contracting authority or contracting entity may limit the number of candidates or tenderers to an appropriate level, on condition that this is done in a transparent manner and on the basis of objective criteria. The number of candidates or tenderers invited shall be sufficient to ensure genuine competition.",'tender','active'
change,Replacement of a previous notice with different information.,'tenderUpdate',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about removing the deprecated code. What if an OCDS for eForms implementation includes notices that use the deprecated code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've been removing deprecated codes in other tables so removing this one would be consistent, e.g. 13d9f12#diff-1a45516eadbe4b0622bb92ce1d65a00ee117f6af1019b663513d001f951f7669

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think OK to remove. Maintaining mappings for multiple versions of eForms is too high effort.

@jpmckinney jpmckinney merged commit add6634 into main Dec 13, 2024
10 checks passed
@jpmckinney jpmckinney deleted the 213-form-type-mapping-table-update branch December 13, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BT-03-Notice: map new form type authority codes to form-type mapping table
3 participants