Skip to content

Commit

Permalink
schema/project-level/project-schema.json: Remove milestone documents
Browse files Browse the repository at this point in the history
  • Loading branch information
duncandewhurst committed Nov 10, 2023
1 parent 748facf commit 2b96cd2
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 52 deletions.
30 changes: 0 additions & 30 deletions docs/_static/i18n.csv
Original file line number Diff line number Diff line change
Expand Up @@ -290,21 +290,6 @@ contractingProcesses/summary/milestones/dueDate,Due date,False,
contractingProcesses/summary/milestones/dateMet,Date met,False,
contractingProcesses/summary/milestones/dateModified,Date modified,False,
contractingProcesses/summary/milestones/status,Status,False,
contractingProcesses/summary/milestones/documents,Documents,False,
contractingProcesses/summary/milestones/documents,Document,False,
contractingProcesses/summary/milestones/documents/id,ID,True,
contractingProcesses/summary/milestones/documents/documentType,Document type,False,
contractingProcesses/summary/milestones/documents/title,Title,True,
contractingProcesses/summary/milestones/documents/description,Description,True,
contractingProcesses/summary/milestones/documents/url,URL,False,
contractingProcesses/summary/milestones/documents/datePublished,Date published,False,
contractingProcesses/summary/milestones/documents/dateModified,Date modified,False,
contractingProcesses/summary/milestones/documents/format,Format,True,
contractingProcesses/summary/milestones/documents/language,Language,True,
contractingProcesses/summary/milestones/documents/pageStart,Page start,True,
contractingProcesses/summary/milestones/documents/pageEnd,Page end,True,
contractingProcesses/summary/milestones/documents/accessDetails,Access details,True,
contractingProcesses/summary/milestones/documents/author,Author,True,
contractingProcesses/releases,Linked releases,False,
contractingProcesses/releases,Release,False,
contractingProcesses/releases/id,ID,True,
Expand Down Expand Up @@ -370,21 +355,6 @@ milestones/dueDate,Due date,False,
milestones/dateMet,Date met,False,
milestones/dateModified,Date modified,False,
milestones/status,Status,False,
milestones/documents,Documents,False,
milestones/documents,Document,False,
milestones/documents/id,ID,True,
milestones/documents/documentType,Document type,False,
milestones/documents/title,Title,True,
milestones/documents/description,Description,True,
milestones/documents/url,URL,False,
milestones/documents/datePublished,Date published,False,
milestones/documents/dateModified,Date modified,False,
milestones/documents/format,Format,True,
milestones/documents/language,Language,True,
milestones/documents/pageStart,Page start,True,
milestones/documents/pageEnd,Page end,True,
milestones/documents/accessDetails,Access details,True,
milestones/documents/author,Author,True,
completion,Completion,False,
completion/endDate,End date,False,
completion/endDateDetails,End date details,True,
Expand Down
13 changes: 1 addition & 12 deletions docs/reference/schema.md
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,6 @@ Each `BudgetBreakdown` has the following fields:
This sub-schema is referenced by the following properties:
* [`documents`](project-schema.json,,documents)
* [`ContractingProcessSummary/documents`](project-schema.json,/definitions/ContractingProcessSummary,documents)
* [`Milestone/documents`](project-schema.json,/definitions/Milestone,documents)

Each `Document` has the following fields:

Expand Down Expand Up @@ -715,16 +714,6 @@ Each `Document` has the following fields:
:title: contractingProcesses/0/summary/documents
```
```{jsoninclude} ../../docs/examples/example.json
:jsonpointer: /projects/0/contractingProcesses/0/summary/milestones/0/documents
:title: contractingProcesses/0/summary/milestones/0/documents
```
```{jsoninclude} ../../docs/examples/example.json
:jsonpointer: /projects/0/milestones/0/documents
:title: milestones/0/documents
```
````
`````
Expand Down Expand Up @@ -1026,7 +1015,7 @@ Each `Milestone` has the following fields:
```{jsonschema} ../../build/current_lang/project-schema.json
:pointer: /definitions/Milestone
:collapse: id,title,type,description,code,dueDate,dateMet,dateModified,status,documents
:collapse: id,title,type,description,code,dueDate,dateMet,dateModified,status
:addtargets:
```
Expand Down
2 changes: 2 additions & 0 deletions manage.py
Original file line number Diff line number Diff line change
Expand Up @@ -740,6 +740,8 @@ def copy_element(name, replacements=None, root='definitions'):
schema['definitions']['Milestone']['properties']['id']['description'] = "A local identifier for this milestone, unique within this block." # noqa: E501
# Original from standard: "Milestone codes can be used to track specific events that take place for a particular kind of contracting process. For example, a code of 'approvalLetter' can be used to allow applications to understand this milestone represents the date an approvalLetter is due or signed." # noqa: E501
schema['definitions']['Milestone']['properties']['code']['description'] = "Milestone codes can be used to track specific events that take place for a particular kind of project or contracting process. For example, a code of 'approvalLetter' can be used to allow applications to understand this milestone represents the date an approvalLetter is due or signed." # noqa: E501
# Remove deprecated milestone documents field
del schema['definitions']['Milestone']['properties']['documents']

copy_element('MilestoneReference', {
# Remove reference to release, add reference to project.
Expand Down
10 changes: 0 additions & 10 deletions schema/project-level/project-schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -1970,16 +1970,6 @@
],
"codelist": "milestoneStatus.csv",
"openCodelist": false
},
"documents": {
"title": "Documents",
"description": "List of documents associated with this milestone (Deprecated in 1.1).",
"type": "array",
"items": {
"$ref": "#/definitions/Document"
},
"uniqueItems": true,
"minItems": 1
}
},
"minProperties": 1
Expand Down

0 comments on commit 2b96cd2

Please sign in to comment.