Update sustainability element titles, removed deleted element, make targets unique #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncandewhurst
changed the title
jpmckinney
approved these changes
Nov 10, 2023
|
|
||
| filename = basedir / 'mapping' / 'sustainability.yaml' | ||
|
|
||
| source = csv_reader( |
There was a problem hiding this comment.
Can you add a comment with a link to the spreadsheet itself?
There was a problem hiding this comment.
Done in 6b1a950
manage.py
Outdated
| @@ -808,6 +808,55 @@ def lint(filename, additional_properties): | |||
| write_yaml_file(filename, elements) | |||
|
|
|||
|
|
|||
| @cli.command() | |||
| def update_sustainability_elements(): | |||
| """Update mapping/sustainability.yaml""" | |||
There was a problem hiding this comment.
How does this interact with update_sustainability_docs?
There was a problem hiding this comment.
This function updates the CoST IDS elements in sustainability.yaml, using the spreadsheet in which CoST maintain the sustainability elements as an input, whilst update_sustainability_docs updates the Markdown mapping documentation, using sustainability.yaml as an input.
I've updated the docstrings in 6b1a950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Description
manage.pyto update the CoST IDS sustainability elements from the spreadsheet in which they are maintained.update-sustainability-docsso that they are uniqueMerge checklist
If there are changes to
project-schema.jsonorproject-package-schema.json:docs/examples/example.jsondocs/examples/blank.json./manage.py pre-committo updatedocs/_static/i8n.csvIf you added a new definition to the schema, run
./manage.py pre-commit.If you added a new codelist:
docs/reference/codelists.md