-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add environment.goals and environmentalGoal.csv #431
Conversation
CI / build (push) appears to be stuck, Details is showing
and has been running for almost 18 minutes now so I'm leaving it for the night and hopefully the runner will come online at some point! @duncandewhurst if it doesn't I'll try and sort it when I'm back in on Thursday. If it does and there's still errors just leave it and I'll sort them on Thursday. If it does and the build passes then please review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy for you to request a review from James once you've resolved my comments.
Co-authored-by: Duncan Dewhurst <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small edits, then good to merge.
Co-authored-by: James McKinney <[email protected]>
Related issues
closes #415
Description
Merge checklist
If there are changes to
project-schema.json
orproject-package-schema.json
:docs/examples/example.json
docs/examples/blank.json
./manage.py pre-commit
to updatedocs/_static/i8n.csv
If you added a new definition to the schema, run
./manage.py pre-commit
.If you added a new codelist:
docs/reference/codelists.md