Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add environment.goals and environmentalGoal.csv #431

Merged
merged 7 commits into from
Nov 21, 2023

Conversation

odscjen
Copy link
Contributor

@odscjen odscjen commented Nov 14, 2023

Related issues

closes #415

Description

Merge checklist

If there are changes to project-schema.json or project-package-schema.json:

  • Update the examples:
    • docs/examples/example.json
    • docs/examples/blank.json
  • Run ./manage.py pre-commit to update docs/_static/i8n.csv

If you added a new definition to the schema, run ./manage.py pre-commit.

If you added a new codelist:

  • Add an entry to docs/reference/codelists.md

@odscjen
Copy link
Contributor Author

odscjen commented Nov 14, 2023

CI / build (push) appears to be stuck, Details is showing

Requested labels: ubuntu-latest
Job defined at: open-contracting/infrastructure/.github/workflows/ci.yml@refs/heads/415_climate_objectives
Waiting for a runner to pick up this job...
Job is waiting for a hosted runner to come online.

and has been running for almost 18 minutes now so I'm leaving it for the night and hopefully the runner will come online at some point!

@duncandewhurst if it doesn't I'll try and sort it when I'm back in on Thursday. If it does and there's still errors just leave it and I'll sort them on Thursday. If it does and the build passes then please review :)

Copy link
Contributor

@duncandewhurst duncandewhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for you to request a review from James once you've resolved my comments.

mapping/sustainability.yaml Outdated Show resolved Hide resolved
schema/project-level/project-schema.json Outdated Show resolved Hide resolved
@odscjen odscjen requested a review from jpmckinney November 16, 2023 09:20
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small edits, then good to merge.

schema/project-level/project-schema.json Outdated Show resolved Hide resolved
schema/project-level/project-schema.json Outdated Show resolved Hide resolved
@odscjen odscjen merged commit 60b9fd0 into 0.9-dev Nov 21, 2023
10 checks passed
@odscjen odscjen deleted the 415_climate_objectives branch November 21, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Climate change objectives
3 participants