-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Financing arrangements #444
Conversation
The build error should be resolved once #428 is merged and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly minor copy editing to conform with the latest work in the OCDS style guide review.
Happy for you to request James' review once you've dealt with my comments
@jpmckinney just checking that this review request is on your radar. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small comments. I assume the schema is copied from the extension.
Co-authored-by: James McKinney <[email protected]>
Yep! I ran ocdskit schema-strict as part of resolving merge conflicts to reinstate validation keywords lost in the merge. |
8ca31ae seems to have removed project milestones in the merge? |
Yep, my mistake. PR to reinstate them: #456 |
Related issues
Description
I also reordered
codelists.md
so that the codelists are in alphabetical order.Merge checklist
If there are changes to
project-schema.json
orproject-package-schema.json
:docs/examples/example.json
docs/examples/blank.json
./manage.py pre-commit
to updatedocs/_static/i8n.csv
If you added a new definition to the schema, run
./manage.py pre-commit
.If you added a new codelist:
docs/reference/codelists.md