chore: Remove noqa (fixed in sqlfluff)

open-contracting · Oct 17, 2024 · d63f24c · d63f24c
1 parent 5428618
commit d63f24c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -19,7 +19,7 @@ repos:
         args: [requirements_dev.in, -o, requirements_dev.txt]
         files: ^requirements(_dev)?\.(in|txt)$
   - repo: https://github.com/sqlfluff/sqlfluff
-    rev: 3.2.2
+    rev: 3.2.4
     hooks:
       - id: sqlfluff-lint
       - id: sqlfluff-fix
diff --git a/sql/middle/agg_parties.sql b/sql/middle/agg_parties.sql
@@ -11,7 +11,7 @@ WITH parties_role_counts AS (
             count(*) AS total_parties_roles
         FROM
             parties_summary
-        -- https://github.com/sqlfluff/sqlfluff/issues/4623#issuecomment-2401209085
+        -- https://github.com/sqlfluff/sqlfluff/issues/4623#issuecomment-2401209085 >3.2.4
         CROSS JOIN jsonb_array_elements_text(roles) AS role -- noqa: AL05
         GROUP BY
             id,

diff --git a/sql/middle/parties_summary.sql b/sql/middle/parties_summary.sql
@@ -32,11 +32,10 @@ SELECT
                     ELSE
                         '[]'::jsonb
                 END
-            -- https://github.com/sqlfluff/sqlfluff/issues/4623#issuecomment-2401209085
+            -- https://github.com/sqlfluff/sqlfluff/issues/4623#issuecomment-2401209085 >3.2.4
             ) AS additional_identifier -- noqa: AL05
         WHERE
-            -- https://github.com/sqlfluff/sqlfluff/pull/6323
-            additional_identifier ?& ARRAY['scheme', 'id'] -- noqa: LT02,PRS
+            additional_identifier ?& ARRAY['scheme', 'id']
     ) AS additionalidentifiers_ids,
     CASE
         WHEN jsonb_typeof(value -> 'additionalIdentifiers') = 'array'