Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema: add submissionTerms.electronicSubmissionPolicy to tender #1654

Merged
merged 7 commits into from
Nov 21, 2023
Merged

schema: add submissionTerms.electronicSubmissionPolicy to tender #1654

merged 7 commits into from
Nov 21, 2023

Conversation

odscjen
Copy link
Contributor

@odscjen odscjen commented Oct 20, 2023 •
edited
Loading

closes #1183 as discussed, i.e. moved submissionTerms.electronicSubmissionPolicy across to tender only

@odscjen odscjen added this to the 1.2.0 milestone Oct 20, 2023
@odscjen odscjen changed the title schema: add submissionTerms.electronicSubmissionPolicy to tender schema: add submissionTerms.electronicCataloguePolicy to tender Oct 20, 2023
@odscjen odscjen changed the title schema: add submissionTerms.electronicCataloguePolicy to tender schema: add submissionTerms.electronicCatalogPolicy to tender Oct 20, 2023
@odscjen odscjen changed the title schema: add submissionTerms.electronicCatalogPolicy to tender schema: add submissionTerms.electronicSubmissionPolicy to tender Oct 20, 2023
jpmckinney
jpmckinney reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoiding a little circularity in the definition.

schema/release-schema.json Outdated Show resolved Hide resolved
@odscjen odscjen requested a review from jpmckinney November 16, 2023 17:23
@odscjen
Copy link
Contributor Author

odscjen commented Nov 16, 2023

@jpmckinney all I did was commit your suggestion and the tests are now failing with a url 404 can't find "https://raw.githubusercontent.com/open-contracting/standard/1183_add_electronicSubmissionPolicy/schema/record-schema.json"? The tests pass on my local machine...

@jpmckinney
Copy link
Member

Had to merge 1.2-dev, and also run manage.py pre-commit.

@jpmckinney jpmckinney merged commit 0594c1a into 1.2-dev Nov 21, 2023
10 checks passed
@jpmckinney jpmckinney deleted the 1183_add_electronicSubmissionPolicy branch November 21, 2023 17:56
jpmckinney added a commit to open-contracting/standard-maintenance-scripts that referenced this pull request Dec 6, 2023
@jpmckinney
test(json): Add permission.csv open-contracting/standard#1654
87b6e6d
@odscjen odscjen mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncandewhurst duncandewhurst duncandewhurst approved these changes

@jpmckinney jpmckinney jpmckinney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Merge the submissionTerms extension
3 participants
@odscjen @jpmckinney @duncandewhurst