-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ImmediateContainer, Quantity and SimplyUnit, clarify Unit use #1689
Conversation
Just a couple comments on the Markdown. I'll review the schema when ready. |
Co-authored-by: James McKinney <[email protected]>
Error Quantity has been lifted straight from the medicine extension, I think the test may need updating |
Noting that I'll correct a "agreeemnts" typo and update the profile template via this PR before merging. |
…k to immediateContainer codelist. Align SimpleUnit, Unit, Classification.
…nning, tender, award, contracts, then alphabetical. Use field paths instead of subschema names if possible.
…d, and Item.unit normative change
I considered adding 'GDSN' to |
…licates schema and that define unit of measurement. Remove instruction about QUDT that is difficult to follow due to QUDT's documentation structure. Don't collapse field that is defined by subschema.
…tifiers within the QUDT scheme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made edits as described in commit messages. @duncandewhurst You might want to review commits individually, skipping the chore and ci commits.
I reviewed the individual commits and ran the pre-commit script to update the dereferenced release schema so that I could review the HTML documentation. The changes look good, but the first sentence of the descriptions of
Anyway, happy for you to merge if you think the descriptions are OK as-is. |
Good call - I'll reword to be more informative. |
For immediate container: ISO_11239_2012(en).PDF
So I'll go with:
|
And I'll simplify to "The unit for pricing the item". |
…diateContainer and unit
…xpression to be escaped, #1689
fix: Some regular expression libraries require a [ inside a bracket expression to be escaped, #1689
closes #1343
draft until comment is agreed upon