Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to metaschema #1723

Open
wants to merge 13 commits into
base: 1.2-dev
Choose a base branch
from
Open

Link to metaschema #1723

wants to merge 13 commits into from

Conversation

duncandewhurst
Copy link
Contributor

@duncandewhurst duncandewhurst commented Nov 28, 2024

Closes #566

To do:

  • Render titles and descriptions for new keywords using a jsonschema directive
  • Add a test to test_schema_integrity.py to make sure all schemas point to the correct metaschema

@duncandewhurst duncandewhurst added this to the 1.2.0 milestone Nov 28, 2024
@duncandewhurst duncandewhurst self-assigned this Nov 28, 2024
@duncandewhurst
Copy link
Contributor Author

@jpmckinney as well as updating$schema, this PR adds titles and descriptions to the new keywords in meta-schema-patch.json and adds the meta schema patch to the resources that get translated, per #566 (comment).

I'm running up against a permission denied error when trying to push the new metaschema resource to Transifex with the following command: tx push -s open-contracting-standard-1-1.metaschema.

In turn, that leads to a build error because there's no message catalogue for the metaschema resource.

Please could you grant me the necessary permissions or create the new resource yourself?

@duncandewhurst duncandewhurst marked this pull request as ready for review December 5, 2024 01:08
@duncandewhurst
Copy link
Contributor Author

@odscjen don't worry about the changes to the config files, makefiles and tests, you can just review the changes to the Markdown and schema files.

Copy link
Contributor

@odscjen odscjen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few copy edit suggestions. As suggested I only reviewed the schema and markdown and only copy edited, this review is not a comment on whether or not some of the technical changes to the schema, e.g. the change to the value of $schema, are correct

schema/meta-schema.json Outdated Show resolved Hide resolved
schema/meta-schema.json Outdated Show resolved Hide resolved
schema/meta-schema.json Outdated Show resolved Hide resolved
schema/meta-schema.json Outdated Show resolved Hide resolved
schema/meta-schema.json Outdated Show resolved Hide resolved
schema/metaschema/meta-schema-patch.json Outdated Show resolved Hide resolved
schema/metaschema/meta-schema-patch.json Outdated Show resolved Hide resolved
schema/metaschema/meta-schema-patch.json Outdated Show resolved Hide resolved
schema/metaschema/meta-schema-patch.json Outdated Show resolved Hide resolved
schema/metaschema/meta-schema-patch.json Outdated Show resolved Hide resolved
@jpmckinney
Copy link
Member

@jpmckinney as well as updating$schema, this PR adds titles and descriptions to the new keywords in meta-schema-patch.json and adds the meta schema patch to the resources that get translated, per #566 (comment).

I'm running up against a permission denied error when trying to push the new metaschema resource to Transifex with the following command: tx push -s open-contracting-standard-1-1.metaschema.

In turn, that leads to a build error because there's no message catalogue for the metaschema resource.

Please could you grant me the necessary permissions or create the new resource yourself?

I added the files like so:

uv run pybabel extract -F babel_ocds_metaschema.cfg -o messages.pot schema/metaschema/meta-schema-patch.json
uv run pybabel init -i messages.pot -d docs/locale -D metaschema -l es
uv run pybabel init -i messages.pot -d docs/locale -D metaschema -l fr

@duncandewhurst
Copy link
Contributor Author

Brill. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review in progress
Development

Successfully merging this pull request may close these issues.

$schema should point to meta-schema incorporating our changes to JSON Schema
3 participants