-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to metaschema #1723
base: 1.2-dev
Are you sure you want to change the base?
Link to metaschema #1723
Conversation
@jpmckinney as well as updating I'm running up against a permission denied error when trying to push the new metaschema resource to Transifex with the following command: In turn, that leads to a build error because there's no message catalogue for the metaschema resource. Please could you grant me the necessary permissions or create the new resource yourself? |
@odscjen don't worry about the changes to the config files, makefiles and tests, you can just review the changes to the Markdown and schema files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few copy edit suggestions. As suggested I only reviewed the schema and markdown and only copy edited, this review is not a comment on whether or not some of the technical changes to the schema, e.g. the change to the value of $schema
, are correct
I added the files like so: uv run pybabel extract -F babel_ocds_metaschema.cfg -o messages.pot schema/metaschema/meta-schema-patch.json
uv run pybabel init -i messages.pot -d docs/locale -D metaschema -l es
uv run pybabel init -i messages.pot -d docs/locale -D metaschema -l fr |
Brill. Thank you! |
Co-authored-by: Jen Harris <[email protected]>
Closes #566
To do:
test_schema_integrity.py
to make sure all schemas point to the correct metaschema