Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Node 18.19.0, support for Keycloak 23" #871

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

aaronchongth
Copy link
Member

Reverts #857

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 977 lines in your changes are missing coverage. Please review.

Comparison is base (fe0e808) 49.35% compared to head (f31fc63) 45.23%.
Report is 44 commits behind head on deploy/hammer.

Files Patch % Lines
packages/dashboard/src/components/map-app.tsx 0.00% 171 Missing ⚠️
.../dashboard/src/components/delivery-alert-store.tsx 0.00% 100 Missing ⚠️
...es/api-server/api_server/models/delivery_alerts.py 12.94% 74 Missing ⚠️
...ackages/react-components/lib/tasks/create-task.tsx 0.00% 68 Missing ⚠️
packages/react-components/lib/tasks/utils.ts 4.76% 54 Missing and 6 partials ⚠️
packages/dashboard/src/components/door-summary.tsx 0.00% 51 Missing ⚠️
packages/dashboard/src/components/lift-summary.tsx 0.00% 50 Missing ⚠️
...shboard/src/components/tasks/task-cancellation.tsx 0.00% 48 Missing ⚠️
...kages/dashboard/src/components/tasks/tasks-app.tsx 0.00% 47 Missing ⚠️
...ckages/api-server/api_server/repositories/tasks.py 37.31% 42 Missing ⚠️
... and 35 more
Additional details and impacted files
@@                Coverage Diff                @@
##           deploy/hammer     #871      +/-   ##
=================================================
- Coverage          49.35%   45.23%   -4.12%     
=================================================
  Files                285      291       +6     
  Lines               7564     8433     +869     
  Branches            1050     1339     +289     
=================================================
+ Hits                3733     3815      +82     
- Misses              3682     4420     +738     
- Partials             149      198      +49     
Flag Coverage Δ
api-server 74.96% <34.34%> (-5.84%) ⬇️
dashboard 13.83% <3.77%> (-1.23%) ⬇️
react-components 44.21% <15.87%> (-3.86%) ⬇️
rmf-auth ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aaronchongth aaronchongth merged commit 65c2991 into deploy/hammer Jan 5, 2024
7 of 8 checks passed
@aaronchongth aaronchongth deleted the revert-857-hammer/bump-node branch January 5, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant