-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chronos V14.0.0 #372
Merged
Merged
Chronos V14.0.0 #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the search bar in the dashboard component was removed from occupied component and given its own folder with associated styles
For easier readability and DX the developer icons sections was extracted into its own component and associated style sheet
Done to facilitate readablity and DX Styles also moved to ApplicationsCard component folder
Modularization
styles block at the top of occupied component was moved into a helper function. Tried to only switch the different styles (background-color, box shadow and another background color) Ran into trouble becuase those styles depend on the mode state which is defined in a context which cant be used outside a function component. Ended up just moving both styling functions whole
The modal component was being rendered multiple times which was unecessary. Additionally each modal component had a different state that was only being used to determine if that modal should be open or not. These states were condensed to one state to simplify the modal states
this commit represents the changes to all the individual modals that are now rendered from a single modal state. Done to clarify which modals are open and prevent unnecessary states
Modularization
updated existing react testing suite
Merge branch 'dev' into modularization
When the app card is clicked the user is now routed to the metrics page If requests from the client have come through the communications tab may be empty. Metrics tab will always be full if the user is successfully collecting server data
Health context refactor
updated main ReadME
removed unused images
sarhiri
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great update on the chronos microservices! Easier for beginners to use and looks so nice. Great job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this @sarhiri , @stephenhyang, @TedPham397
Types of changes
Updates: