Explicitly state compatible python versions in pyproject.toml #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
via the queue into
open-spaced-repetition:main
with commit Dec 19, 2024
9b9b700
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FSRS-Optimizerpackage relies on pytorch which is currently incompatible with python3.13.If you run
pip install FSRS-Optimizerwith python3.13, you'll get a dependency conflict error and won't be able to install the package.Given this, I modified the pyproject.toml to explicitly state which versions of python are currently compatible with this package.
Let me know if there are any questions/etc 👍