Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define NT_TIB[32/64] types in winnt.h #1348

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

ivmai
Copy link
Contributor

@ivmai ivmai commented Nov 18, 2024

NT_TIB, NT_TIB32, NT_TIB64 types should be defined in h/nt/winnt.h, duplicating the definitions in h/nt/ddk/ntddk.h.

@ivmai
Copy link
Contributor Author

ivmai commented Nov 18, 2024

Sample usage of NT_TIB (in client code): https://github.com/ivmai/bdwgc/blob/2ea2415a60ccc3393d3d235f73b4cab6f6fa8221/win32_threads.c#L859
I've tested this PR in the given project.

@jmalak
Copy link
Member

jmalak commented Nov 18, 2024

Hi,
Thank you for your patch.
Please, rework it little bit following way.
create file bld/w32api/include/nttib.sp which will contain only NT_TIB related structure definitions which exist in bld/w32api/include/ddk/ntddk.mh and is missing in winnt.h.
remove this info from bld/w32api/include/ddk/ntddk.mh and replace it by single line
:include nttib.sp
add same line to bld/w32api/include/winnt.mh on correct position

It will fix appropriate header files as you proposed but ensure that single definition exists in nttib.sp and it is included to both header files.

@ivmai
Copy link
Contributor Author

ivmai commented Nov 18, 2024

Okay

NT_TIB, NT_TIB32, NT_TIB64 types should be defined in h/nt/winnt.h and
in h/nt/ddk/ntddk.h.
@ivmai
Copy link
Contributor Author

ivmai commented Nov 18, 2024

Please, rework it little bit following way.

Done

@jmalak jmalak merged commit 12c10fd into open-watcom:master Nov 18, 2024
10 checks passed
@jmalak
Copy link
Member

jmalak commented Nov 18, 2024

Many thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants