Fixed the login screen crash problem which occurs when we fill wrong login details. #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darkeye14
reviewed
Dec 23, 2024
| @@ -18,4 +18,5 @@ | |||
| <string name="feature_auth_error_password_length">Invalid password length</string> | |||
| <string name="feature_auth_error_not_connected_internet">No Internet Connection</string> | |||
| <string name="feature_auth_error_login_failed">Login Failed, Please Try Again Later.</string> | |||
| <string name="feature_auth_error_unexpected">Unexpected Error Please Enter the valid Login details</string> | |||
There was a problem hiding this comment.
Would you mind changing the string name to feature_auth_error_wrong_credentials ???
There was a problem hiding this comment.
@Darkeye14 I made the required changes may you please review it
itsPronay
reviewed
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…login details.
Fixes #Issue_Number
Screen.Record.of.the.login.screen.correction.mp4
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.