Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: moving files from database module to model module #2275

Merged
merged 7 commits into from
Jan 8, 2025
Merged

refactor: moving files from database module to model module #2275

merged 7 commits into from
Jan 8, 2025
+1,408 −1,332

Conversation

Darkeye14
Copy link
Contributor

Fixes JIRA

WhatsApp.Video.2024-12-27.at.16.15.22_f262dee6.mp4

@itsPronay
Copy link
Contributor

itsPronay commented Dec 27, 2024 •
edited
Loading

@Darkeye14 There are some classes like Loan, Loans, CenterAccounts etc that are not annotated with @ModelContainer and yet they are still part of the database module. Could you please clarify!

image

@Darkeye14
Copy link
Contributor Author

@Darkeye14 There are some classes like Loan, Loans, CenterAccounts etc that are not annotated with @ModelContainer and yet they are still part of the database module. Could you please clarify!

image

Bhai, ive explained it on slack bhai

@therajanmaurya
Copy link
Member

@niyajali Review

niyajali
niyajali requested changes Jan 6, 2025
View reviewed changes
core/network/src/main/java/com/mifos/core/network/mappers/centers/CenterMapper.kt Outdated Show resolved Hide resolved
core/database/src/main/java/com/mifos/core/data/LoansPayload.kt Outdated
@@ -10,7 +10,7 @@
package com.mifos.core.data

import android.os.Parcelable
import com.mifos.core.objects.noncore.DataTablePayload
import com.mifos.core.dbobjects.noncore.DataTablePayload
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this files in network model package and why we need payload in database module if you needed that data class than rename to LoanEntity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha bhaiya, ive moved it to network module and the rest of them are moved to model module.

@Darkeye14
renaming dbobjects to entity
1168f51 
refactoring CenterPayload file
moving LoanPayload to network module
@Darkeye14
Copy link
Contributor Author

Everything done Bhaiya

@therajanmaurya therajanmaurya merged commit b2c41c3 into openMF:master Jan 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niyajali niyajali niyajali requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Darkeye14 @itsPronay @therajanmaurya @niyajali