Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download script improvements #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Download script improvements #6

wants to merge 4 commits into from

Conversation

akx
Copy link

@akx akx commented Jun 11, 2019 •
edited
Loading

This PR:

  • makes sure the download script doesn't clobber any existing files if they seem correct enough (same size as remote)
  • ensures 404, etc. errors don't get written as outputs (by raising an error when they occur)
  • uses a larger read chunk size for a modest speed boost; there's no need to read and write things 1000 bytes at a time

@WuTheFWasThat WuTheFWasThat force-pushed the master branch 3 times, most recently from 2802ab0 to cba7812 Compare August 20, 2019 00:32
@WuTheFWasThat
Copy link
Contributor

sorry for getting to this so late, could you resolve the conflicts and i'll take another look?

@akx akx force-pushed the dl-improvements branch from 5c0b1c2 to b4285b9 Compare February 3, 2023 17:19
@akx
Copy link
Author

akx commented Feb 3, 2023

@WuTheFWasThat Rebased!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akx @WuTheFWasThat