Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomHeaderAuthenticationBackend to run container proxy behind trusted http proxy #81

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

raulbla
Copy link

@raulbla raulbla commented Oct 14, 2023

I have tried to implemented what suggested openanalytics/shinyproxy#297.
Right now the authentication part is covered. So if you have a web server (eg. Apache HTTPD) which authenticates the users than the authentication header can be used to authenticate in ShinyProxy.

@LEDfan
Copy link
Member

LEDfan commented Oct 23, 2023

Hi, thanks a lot for opening this PR! We will include this in the next release!
I will merge this PR locally and push the changes to github before then next release.
Thanks again :)

@LEDfan LEDfan added the enhancement New feature or request label Oct 23, 2023
@LEDfan LEDfan changed the base branch from master to develop March 21, 2024 13:17
@LEDfan LEDfan force-pushed the develop branch 3 times, most recently from eeb13a8 to 60e34cf Compare May 7, 2024 08:13
@steven-sun
Copy link

@LEDfan Hi, when will this commit be merged? this will be very helpful in my current project, thanks a lot!

@LEDfan
Copy link
Member

LEDfan commented Jul 1, 2024

Hi @steven-sun , @raulbla , while working on the latest release, I tests this code but it wasn't working for me.
Could you please check whether your code still works with the latest release? I'll then further review it.

@raulbla
Copy link
Author

raulbla commented Aug 13, 2024

Hi thanks for the hands up.
It was necessary a porting to java 17.
Can you double check please?

@danibo
Copy link

danibo commented Aug 22, 2024

It would be great to have this feature!

@FedericoBianca
Copy link

Hi @LEDfan, do you think we'll have this new feature in the next release? I'm using it with Java17 and behind an Apache HTTP server it works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants