Add issue templates for code synchronization #87
Conversation
…endatahub-io#18) **What this does / why we need it**: This PR adds custom code to make KServe run on OpenShift without the need for anyuid SCC. **More context**: OpenShift uses istio-cni which causes an issue with init-containers when calling external services like S3 or similar. Setting the uid for the storage-initializer to the same uid as the uid of the istio-proxy resolves the issue. In OpenShift the istio-proxy always gets assigned the first uid from the namespaces uid range + 1 (The range is defined in an annotation on the namespace). **Release note**: ```release-note The `storage-initializer` container will now run with the same `uid` as the `istio-proxy` which resolves an issue when istio-cni is used. ``` --- Squashed commit titles: * add storage-initializer uid handling for OpenShift with istio-cni * update storage_initializer_injector tests * Also use annotation on pod to override uid
* Remove manager's rbac-proxy and add ODH requried network policies * Workaround for Kustomize bug about creationTimestamp See: kubernetes-sigs/kustomize#5031 Without this workaround, some Kustomize versions are generating `creationTimestamp: "null"` (null as a string). Signed-off-by: Edgar Hernández <[email protected]>
* Workflows are changed to push to Quay.io. * The go.yml workflow is changed to omit updating the coverage badge (we don't have one, for now). * The README.md file is updated to right ODH urls. Signed-off-by: Edgar Hernández <[email protected]>
…ge-push Adapt GH-workflows to correctly push to ODH container repositories
Kustomize patches for OpenShift were cherry-picked from the release-v0.10 branch. The cherry-pick succeeded, but the resulting manifests were not working, because of the differences. This fixes the manifests and bring them back to a working state. Signed-off-by: Edgar Hernández <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The issue template covers both synchronization with upstream repositories, and also manifest replication to `odh-manifest` repository.
israel-hdez
force-pushed
the
upstream-sync-template
branch
from
3e48e05 to
b2631c2
Compare
|
@israel-hdez does it still valid? |
|
Apparently the change looks good, however, wouldn't be better to use the README or another .md file instead a template? |
Hmm... So, this PR has been here for some time. But now that we moved back to Jira, an issue template no longer makes sense. So, you are right. Well... @spolti you already have done a few code syncs. I think if you find the content useful, I can rework the PR to be a simple |
|
@israel-hdez I think we can keep it, it is useful for new contributors. |
|
/retest |
|
not related: Error: failed to create iam: LimitExceeded: Cannot exceed quota for OpenIdConnectProvidersPerAccount: 100 /retest |
|
Now that it passed, I see this is an issue template. |
+1 |
|
Hi @israel-hdez, is this something that you plan to continue working on? |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
The issue template covers both synchronization with upstream repositories, and also manifest replication to
odh-manifestrepository.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Related to opendatahub-io/modelmesh-serving#188