Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ruby deps for v3.3 #114

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update Ruby deps for v3.3 #114

wants to merge 5 commits into from

Conversation

garaud
Copy link

@garaud garaud commented Sep 13, 2024

  • update the README file

  • update the version of some dependencies

    Now you use a Ruby v3.3

  • update the config about the sprockets tool for Javascript files

    As middleman v4 can handle .scss files, sprockets failed to compile some '.css'
    files which had been already compiled. Just told to sprockets to handle '.js' files.

  • update the link to the main api page

    which is now to 'https://community.opendatasoft.com/p/developers'

How to Review

  • mainly follow the README.md file which has been updated
  • Ruby 3.2 or 3.3 should work
  • check the build when you bundle exec middleman build and check one or more page when you bundle exec middleman serve
  • the HTML pages should look like to the pages deployed in https://help.opendatasoft.com/apis/wfs-v2/#wfs-api for instance.

As middleman v4 can handle .scss files, sprockets failed to compile some '.css'
files which had been already compiled. Just told to sprockets to handle '.js' files.
@garaud garaud changed the title Chore/update uby deps for v3.3 and Update Ruby deps for v3.3 Sep 13, 2024
update for Ubuntu 20.04 (focal)

the default one is xenial 16.04 which is quite old.
@garaud garaud force-pushed the chore/update-ruby-deps branch from 00ec46c to 107c0b7 Compare September 13, 2024 16:48
@garaud garaud requested a review from NTerpo September 13, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant