Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support plugin vdW interactions without electrostatics #695

Merged
merged 3 commits into from
May 1, 2023
Merged

Support plugin vdW interactions without electrostatics #695

merged 3 commits into from
May 1, 2023

Conversation

mattwthompson
Copy link
Member

Description

This PR fixes an assumption in the OpenMM export logic that a vdW collection exists with that name as a non-plugin.

Checklist

  • Test in Evaluator test environment
  • Add tests
  • Lint
  • Update docstrings

@codecov
Copy link

codecov bot commented May 1, 2023 •
edited
Loading

Codecov Report

Merging #695 (5f5f720) into main (c7b9c6d) will increase coverage by 0.63%.
The diff coverage is 100.00%.

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review May 1, 2023 19:54
@mattwthompson
Copy link
Member Author

This is needed for openforcefield/openff-evaluator#512 but something else is also needed.

@mattwthompson mattwthompson merged commit 83f0677 into main May 1, 2023
@mattwthompson mattwthompson changed the title FIX: Do not assume vdW handler exists Support plugin vdW interactions without electrostatics May 2, 2023
@mattwthompson mattwthompson deleted the fix-694 branch August 25, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattwthompson