-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Des370k monomer lowest energy conformer optimization #421
base: master
Are you sure you want to change the base?
Conversation
QCSubmit Validation Report
QC Specification Report
QCSubmit version information(click to expand)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nonblocking The parent dataset and other SPICE associated datasets include the scf_property, "mbis_charges". You might include it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'll leave this open in case @amcisaac wants to add mbis_charges, but otherwise feel free to merge and we can get compute up over the weekend! |
Ah sure I will add that keyword, thanks for the suggestion. |
Okay this should be ready to go, but I won't merge until I get the go ahead that @jaclark5 has gotten set up on NRP. I tried to resolve the conflict in the overall README myself with a commit but it doesn't seem to have worked, that should be a very simple fix but using the "resolve conflicts" button tried to merge it so I haven't done it yet. |
This is a standard
OptimizationDataset
, and so does not rely on any updates to QCSubmit/GeomeTRIC, so should be ready to go.I've named it v4.0 as it should conform to the new standards, but I'm not sure if non-OpenFF datasets should still have that version.
New Submission Checklist
README.md
describing the dataset see here for examplesdataset*.json
; may feature a compression extension, such as.bz2
README.md