Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use path for mdoc #368

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Use path for mdoc #368

merged 3 commits into from
Jan 15, 2025

Conversation

danielfett
Copy link
Contributor

No description provided.

@danielfett danielfett marked this pull request as ready for review December 12, 2024 17:26

The result of the processing is the set of selected JSON elements.

## Semantics for ISO mdoc-based credentials
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this section here and not in the mdoc credential format appendix? It's explicitly for ISO mdoc, so I don't understand why it should be here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think for the symmetry with JSON-based credentials section. will merge as-is since there are enough approvals and no other blockers. we can fix this later if necessary, as we did with the mdoc section in the very first DCQL PR.

@babisRoutis
Copy link

A question from my side: In the mdoc case, is it valid to have a path with a single element (the namespace)?

If not, should somehow this constraint appear on the spec in the mdoc section?

@Sakurann
Copy link
Collaborator

A question from my side: In the mdoc case, is it valid to have a path with a single element (the namespace)?

If not, should somehow this constraint appear on the spec in the mdoc section?

my understanding is that path for mdoc always has at least 2 elements, so we should make that clear

@babisRoutis
Copy link

A question from my side: In the mdoc case, is it valid to have a path with a single element (the namespace)?
If not, should somehow this constraint appear on the spec in the mdoc section?

my understanding is that path for mdoc always has at least 2 elements, so we should make that clear

It seems that I hadn't read carefully the PR.
Indeed, PR contains a constraint for mdoc path that suggests that it should have exactly two elements.

@Sakurann Sakurann merged commit d66c8fa into main Jan 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants