Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346887: DrawFocusRect() may cause an assertion failure #3199

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

satyenme
Copy link

@satyenme satyenme commented Jan 10, 2025

Backporting JDK-8346887: DrawFocusRect() may cause an assertion failure. Minor change that adds an additional check before running an assertion for windows. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests. Patch is clean.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8346887 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8346887: DrawFocusRect() may cause an assertion failure (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3199/head:pull/3199
$ git checkout pull/3199

Update a local copy of the PR:
$ git checkout pull/3199
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3199/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3199

View PR using the GUI difftool:
$ git pr show -t 3199

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3199.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 8eddf67c82a2af4d704c4063ad802640770b3c26 8346887: DrawFocusRect() may cause an assertion failure Jan 10, 2025
@openjdk
Copy link

openjdk bot commented Jan 10, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 10, 2025
@satyenme
Copy link
Author

/approval request for backport. Minor change that adds an additional check before an assertion for windows. Tested with tier1, tier2, and GHA tests. Risk is low.

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

@satyenme
8346887: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 10, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 10, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant