8233179: VetoableListDecorator#sort throws IllegalArgumentException "duplicate children"

[mstr2]

The VetoableListDecorator class does not override the default implementation of List.sort(). The default implementation copies the elements into an array, sorts the array, and then calls List.set() in a loop to sort the List without removing the old elements first. This leads to the VetoableListDecorator intercepting the call to set() and seeing a "duplicate child" being added.

The solution is to implement SortableList.doSort() with the following protocol:

1. Make a copy of the list and sort it.
2. Present the sorted list with onProposedChange for a potential veto.
3. If successful, use setAll() to swap out the current list with the sorted list.

/reviewers 2

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8233179: VetoableListDecorator#sort throws IllegalArgumentException "duplicate children" (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1674/head:pull/1674
$ git checkout pull/1674

Update a local copy of the PR:
$ git checkout pull/1674
$ git pull https://git.openjdk.org/jfx.git pull/1674/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1674

View PR using the GUI difftool:
$ git pr show -t 1674

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1674.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mstrauss! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@mstr2
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[mlbridge]

Webrevs

• 00: Full (978d2dd2)